Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw meaningful exception when no resources are found #11

Merged

Conversation

JaZo
Copy link
Member

@JaZo JaZo commented Mar 29, 2023

Description

I've added a meaningful exception when no resources are found.

Motivation and context

You get a meaningless error about a type mismatch when there are no resources found because you forgot to seed the database.

How has this been tested?

Tested with an empty database.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

@JaZo JaZo requested a review from tommie1001 March 29, 2023 09:15
@JaZo JaZo merged commit ea54080 into master Mar 29, 2023
@JaZo JaZo deleted the feature/throw-meaningful-exception-when-no-resources-are-found branch March 29, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants